Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry: Measure docs usage #19648

Merged
merged 3 commits into from
Oct 28, 2022
Merged

Telemetry: Measure docs usage #19648

merged 3 commits into from
Oct 28, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 27, 2022 •
edited
Loading

Issue: N/A

What I did

  • Fix storyCount for v7 (we were overcounting)
  • Track different types of docs entries (docsPage, storiesMdx, mdx)
  • Fix boot notification

How to test

We'll be adding proper testing for this soon. For now, manually:

  • STORYBOOK_TELEMETRY_DEBUG=true and enable telemetry

@shilman shilman added the maintenance User-facing maintenance tasks label Oct 27, 2022
@shilman shilman changed the title Telemetry: Track docs usage Telemetry: Measure docs usage Oct 27, 2022
@shilman shilman requested a review from tmeasday October 27, 2022 12:55
tmeasday
tmeasday approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman marked this pull request as ready for review October 28, 2022 06:16
@shilman shilman closed this Oct 28, 2022
@shilman shilman reopened this Oct 28, 2022
@shilman shilman merged commit 298c9e9 into next Oct 28, 2022
@shilman shilman deleted the shilman/track-docs-usage branch October 28, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday