-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show docspage unless the user opts in #19627
Don't show docspage unless the user opts in #19627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
What are the semantics of adding docsPage
to an individual story? Error? Warn? Ignore?
…sb-831-only-generate-docs-page-for-tagged
It's ignore at this point. I guess from my perspective it doesn't make sense as the docs are attached to the component, so I wouldn't expect people to do it, but I'm probably too "deep" at this point. We could warn? |
…ate-docs-page-for-tagged
…-storiesof-via-parameters Allow setting tags in storiesOf via parameters.
…ate-docs-page-for-tagged
Telescoping on #19625 (and therefore only currently works in v6 store).
What I did
docsPage
tag.How to test
Run a sandbox, check out all stories compared to docs page stories