Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test-runner version conflicts #19581

Merged
merged 1 commit into from
Oct 22, 2022
Merged

Fix test-runner version conflicts #19581

merged 1 commit into from
Oct 22, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 22, 2022

Issue: N/A

What I did

  • Upgraded to @storybook/test-runner@next in sandboxes
  • Upgraded to @storybook/csf@next across the board

Now the monorepo & test-runner both depend on csf@next so that yarn linking works. Furthermore test-runner@next depends on monorepo@next, so that duplicate packages are no longer installed.

How to test

  • CI passes

@shilman shilman requested a review from tmeasday October 22, 2022 09:36
tmeasday
tmeasday approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@shilman shilman merged commit 31c93aa into next Oct 22, 2022
@shilman shilman deleted the shilman/fix-test-runner-version-conflicts branch October 22, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday