Telemetry: Use a wrapper around all CLI commands to send boot and error events #19566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
commented
Oct 21, 2022
| @@ -260,7 +262,7 @@ export async function initiate(options: CommandOptions, pkg: Package): Promise<v | |||
| logger.log(chalk.inverse(`\n ${welcomeMessage} \n`)); | |||
|
|
|||
| if (!options.disableTelemetry) { | |||
| telemetry('init'); | |||
| telemetry('init', {}, { stripMetadata: true }); | |||
There was a problem hiding this comment.
This was failing trying to find the metadata. I'm not really sure what changed, but we don't need it / can't find it anyway.
shilman
reviewed
Oct 21, 2022
shilman
approved these changes
Oct 21, 2022
Co-authored-by: Michael Shilman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: we lost error telemetry in 7.0 somehow.
What I did
withTelemetrywrapper to deal with errors consistentlyHow to test