Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix grammer mistake on introduction page #19502

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

yourcasualdev
Copy link
Contributor

@yourcasualdev yourcasualdev commented Oct 15, 2022

Issue: Grammer mistake on docs/writing-stories/introduction.md

What I did

Changed line 86 on introduction.md

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nightvision53 I left a small item that requires your attention. Once you've addressed it, let me know and I'll gladly merge this.

Hope you have a great weekend.

Stay safe

docs/writing-stories/introduction.md Outdated Show resolved Hide resolved
@jonniebigodes jonniebigodes self-assigned this Oct 15, 2022
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 15, 2022
Add missing comma to /docs/writing-stories/introduction.md line 86.
@jonniebigodes
Copy link
Contributor

@Nightvision53 Thanks for addressing the feedback so promptly 🙏 ! Merging this.

@jonniebigodes jonniebigodes merged commit 1b333b1 into storybookjs:next Oct 16, 2022
@yourcasualdev
Copy link
Contributor Author

@jonniebigodes This is my first contribution to open source. It's just a comma but means a lot to me. 🙏

@jonniebigodes
Copy link
Contributor

@Nightvision53, that's great to hear, and congratulations are in order, so it seems 🎊 🎉 !

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 24, 2022
shilman pushed a commit that referenced this pull request Oct 24, 2022
fix grammer mistake on introduction page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants