remove the defaultValue feature for argTypes

[ndelangen]

remove the deprecated defaultValue property api for argTypes

[ndelangen]

@shilman I'd like your review on this.. I commented out the test code, because I didn't know if I should remove it or modify it, please advice what you'd like me to do about that.

I also suspect that there might be stories (in our own codebase) out there somewhere that use this deprecated feature?

[tmeasday]

Yes, I think I discovered in the angular work that it is still setting default values from compodoc (which is often very annoying, TBH). Still it might make it a disruptive changes for angular users.

Probably we need to pull the bandaid though.

[ndelangen]

Discussed with @shilman he'll take a look at this, when he has time.

I'll continue with other deprecations removal work.

[ndelangen]

This is one of the few remaining ones @tmeasday @shilman

[tmeasday]

@ndelangen I think you should play around with some of the angular stories with and without this change. For example this line of code:

https://github.com/storybookjs/storybook/blob/next/code/frameworks/angular/template/stories/argTypes/doc-button/doc-button.component.ts#L52

I'm pretty sure it leads to an argType.defaultValue being set for the story automatically to { theDefaultValue: 'Default value in component' }. I'm also pretty sure we changed the react docgen->argTypes implementation so that wouldn't happen (in the equivalent situation.

[ndelangen]

@shilman Do you think it's possible for us to resolve this together on Monday? and get this merged?

[shilman]

@ndelangen Sure! Let's do it

[tmeasday]

@ndelangen sorry for the delay here, I got to the bottom of it: #19935