Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Bundle addons/highlight with ts-up #19483

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Build: Bundle addons/highlight with ts-up #19483

merged 3 commits into from
Oct 17, 2022

Conversation

bryanjtc
Copy link
Member

@bryanjtc bryanjtc commented Oct 14, 2022 •
edited by ndelangen
Loading

Related: #18732

What I did

Followed the instructions in the above issue

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@IanVS IanVS mentioned this pull request Oct 14, 2022
Closed
@IanVS IanVS changed the title chore: Migrated addons/highlight to tsup Build: Bundle addons/highlight with ts-up Oct 14, 2022
@IanVS IanVS added the build Internal-facing build tooling & test updates label Oct 14, 2022
@ndelangen ndelangen merged commit 77d3cbd into storybookjs:next Oct 17, 2022
@ndelangen ndelangen self-assigned this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS left review comments

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryanjtc @ndelangen @IanVS