Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable @storybook/nextjs framework in CLI #19478

Merged
merged 8 commits into from
Oct 21, 2022
Merged

Enable @storybook/nextjs framework in CLI #19478

merged 8 commits into from
Oct 21, 2022

Conversation

kylegach
Copy link
Contributor

@kylegach kylegach commented Oct 13, 2022 •
edited
Loading

What I did

  • Add nextjs/default-js & nextjs/default-ts repro templates to CI config
  • Remove "feature flag" around CLI project detection of nextjs

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@kylegach kylegach changed the title Add nextjs repros to ci Enable @storybook/nextjs framework in CLI Oct 13, 2022
@kylegach kylegach mentioned this pull request Oct 13, 2022
Merged
3 tasks
Base automatically changed from nextjs-framework-support to next October 21, 2022 14:37
shilman
shilman approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@shilman shilman merged commit a21931e into next Oct 21, 2022
@shilman shilman deleted the nextjs-framework-add-to-ci branch October 21, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
feature request nextjs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylegach @shilman @yannbf