Cleanup framework angular dependencies #19389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think right now.. the dependency on react can't be removed... I think? |
|
Who is responsible for providing a react-version in this mono-repo? Nothing references react in frameworks/angular. I assumed that react is provided by a different package that needs react installed. I can undo that, though. Any way to test if this change is ok or not? |
|
The test runner figured out that something is missing :) I get the tests green first, lets discuss further changes aftwards |
kroeder
force-pushed
the
framework-angular-cleanup-dependencies
branch
from
3208215 to
4ec4e23
Compare
|
@ndelangen do you need anything else? |
According to `npx depcheck`, the dependencies in this commit can be removed.
The dependency @storybook/core-webpack is being referenced in angular/src/types.ts but not listed as dependency.
kroeder
force-pushed
the
framework-angular-cleanup-dependencies
branch
from
4ec4e23 to
585596c
Compare
ndelangen
approved these changes
Oct 17, 2022
kroeder
commented
Oct 17, 2022
Co-authored-by: Kai Röder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I noticed that the framework/angular/package.json needed a cleanup.
For checking missing or obsolete dependencies, I used
npx depcheck code/frameworks/angularHow to test
If your answer is yes to any of these, please make sure to include it in your PR.