Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add react17 + webpack5 template #19342

Merged
merged 8 commits into from
Oct 5, 2022
Merged

add react17 + webpack5 template #19342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7cdb341
add a template for react17
ndelangen Oct 4, 2022
7882c4c
add branch
ndelangen Oct 4, 2022
b26c920
fix branch name
ndelangen Oct 4, 2022
7a286c2
increase parallelism
ndelangen Oct 4, 2022
fbc3db6
Merge branch 'norbert/sb-524-webpack5react18ts' into norbert/sb-525-w…
ndelangen Oct 5, 2022
9f712a4
Merge branch 'norbert/sb-524-webpack5react18ts' into norbert/sb-525-w…
ndelangen Oct 5, 2022
d17268a
Merge branch 'norbert/sb-524-webpack5react18ts' into norbert/sb-525-w…
ndelangen Oct 5, 2022
b36a96f
Merge branch 'next' into norbert/sb-525-webpack5react17js
ndelangen Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 11
parallelism: 12
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -336,7 +336,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 10
parallelism: 11
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -352,7 +352,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 11
parallelism: 12
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -372,7 +372,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 11
parallelism: 12
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -388,7 +388,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 11
parallelism: 12
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -404,7 +404,7 @@ jobs:
executor:
class: medium+
name: sb_playwright
parallelism: 11
parallelism: 12
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/generate-repros-next.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
branches:
- vite-frameworks-xyz
- norbert/sb-524-webpack5react18ts
- norbert/sb-525-webpack5react17js

jobs:
generate:
Expand Down
10 changes: 10 additions & 0 deletions code/lib/cli/src/repro-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,16 @@ const reactWebpackTemplates = {
builder: '@storybook/builder-webpack5',
},
},
'react-webpack/17-ts': {
name: 'React Webpack5 (TS)',
script: 'yarn create webpack5-react . --version-react="17" --version-react-dom="17"',
cadence: ['ci', 'daily', 'weekly'],
expected: {
framework: '@storybook/react-webpack5',
renderer: '@storybook/react',
builder: '@storybook/builder-webpack5',
},
},
};

const vue3ViteTemplates = {
Expand Down