Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bootstrap+sandbox into "task" framework #19275

Merged
merged 85 commits into from
Oct 10, 2022
Merged
Changes from 1 commit
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
d24daef
Got task script mostly working
tmeasday Sep 27, 2022
08afa9b
Switch flag in CI scripts
tmeasday Sep 30, 2022
5dabf4e
Switch create task
tmeasday Sep 30, 2022
f003645
Ensure the sandboxes dir exist
tmeasday Sep 30, 2022
dbdf5ac
Need to reset back to create for the create-sandboxes step
tmeasday Sep 30, 2022
3211f87
Don't link in CI
tmeasday Sep 30, 2022
67677da
Show status of script
tmeasday Sep 30, 2022
46b67aa
Move `run-registry` before `create`
tmeasday Sep 30, 2022
3eada14
Always debug the final task
tmeasday Sep 30, 2022
a2ffd0f
Start earlier
tmeasday Sep 30, 2022
832de09
Only go to the end :shrug:
tmeasday Sep 30, 2022
1272940
Add the concept of a service task and step through tasks more carefully
tmeasday Oct 3, 2022
626fa54
Recombine sandbox task.
tmeasday Oct 3, 2022
364a299
Update circl
tmeasday Oct 3, 2022
c9c3de3
Clean up a lot of older code
tmeasday Oct 3, 2022
c391e7e
Smal lfix
tmeasday Oct 3, 2022
3f4b5c3
Merge remote-tracking branch 'origin/next' into tom/sb-628-properly-d…
tmeasday Oct 3, 2022
0b97078
Fixes
tmeasday Oct 3, 2022
c28134f
Fix merge conflict
tmeasday Oct 3, 2022
55d0a25
Cleanup
tmeasday Oct 3, 2022
3d3f6a9
More fix
tmeasday Oct 3, 2022
17b12ae
Another fix
tmeasday Oct 3, 2022
56b504b
Add top-level package.json and use for `yarn start/task`
tmeasday Oct 4, 2022
ecff39f
Bootstrap directly in the bootstrap task
tmeasday Oct 4, 2022
c3cf976
Update `--reset` to `--start-from`
tmeasday Oct 4, 2022
be23ced
Delete bootstrap!
tmeasday Oct 4, 2022
d45a6f3
Add a nice CI error to help repros
tmeasday Oct 4, 2022
c19b4b5
Merge remote-tracking branch 'origin/next' into tom/sb-628-properly-d…
tmeasday Oct 4, 2022
6d6a432
Replace some uses of bootstrap
tmeasday Oct 4, 2022
229a912
No need to mess with task controllers
tmeasday Oct 5, 2022
b25a326
Refactor sandbox to load async
tmeasday Oct 5, 2022
a396d3a
Updates to package.json to make things simpler
tmeasday Oct 5, 2022
5af3929
Fix bootstrap
tmeasday Oct 5, 2022
8a7328f
Deepscan
tmeasday Oct 5, 2022
f0ab6e6
Fix bootstrap
tmeasday Oct 5, 2022
b1f8c45
Keep fixing bootstrap until it works
tmeasday Oct 5, 2022
f3dd526
Commit top-level yarn.lock
tmeasday Oct 5, 2022
6c51c55
Merge remote-tracking branch 'origin/next' into tom/sb-628-properly-d…
tmeasday Oct 5, 2022
d5b05d2
Let's debug bootstrap
tmeasday Oct 5, 2022
e4e7344
Don't need to run `task` from `code/` anymore
tmeasday Oct 5, 2022
3f3f428
Rename tasks in a simpler way
tmeasday Oct 5, 2022
843811a
Slightly nicer prompt message
tmeasday Oct 5, 2022
431162b
Add basic contributing instructions and improve prompts
tmeasday Oct 5, 2022
ca2e2c8
Add `get-template` to root
tmeasday Oct 5, 2022
ee60b3a
Check in root node modules
tmeasday Oct 5, 2022
059798a
Merge remote-tracking branch 'origin/next' into tom/sb-628-properly-d…
tmeasday Oct 6, 2022
c67791a
Fix get-template
tmeasday Oct 6, 2022
03c7e17
Ensure we get workspaces from` code/`
tmeasday Oct 6, 2022
9373838
Fix start task
tmeasday Oct 6, 2022
fed5708
Fix `esbuild-loader` resolution
tmeasday Oct 6, 2022
8204a4c
Fix compile readiness
tmeasday Oct 6, 2022
443faaa
Final task should always run
tmeasday Oct 6, 2022
f527257
More fixes so things actually run
tmeasday Oct 6, 2022
aa0f826
Made changes to `code.md`
tmeasday Oct 6, 2022
6e7b08d
Get rid of references to bootstrap
tmeasday Oct 6, 2022
4154353
Fix tasks
tmeasday Oct 6, 2022
3991921
Fix up serve task
tmeasday Oct 6, 2022
a638acc
Add logging for a minute
tmeasday Oct 6, 2022
202feac
Revert "Add logging for a minute"
tmeasday Oct 6, 2022
f37897d
Switch CRA for vite-react in `start`
tmeasday Oct 7, 2022
44b1131
Allow starting from a service
tmeasday Oct 7, 2022
2c898fb
Update scripts/task.ts
tmeasday Oct 7, 2022
67d1ab1
Rename `before` => `dependsOn`
tmeasday Oct 9, 2022
da590c7
Remove spurious log
tmeasday Oct 9, 2022
0aa4be1
Remove `a11y` from default addons
tmeasday Oct 9, 2022
6adbd3e
Move text up
tmeasday Oct 9, 2022
d1ebd7e
Apply suggestions from code review
tmeasday Oct 9, 2022
f407585
Another @yannbf fix
tmeasday Oct 9, 2022
57c81e8
Rename file to `storybook-sandbox`
tmeasday Oct 9, 2022
0c9639b
Just specify a template for simplicity
tmeasday Oct 9, 2022
f67404b
Ensure that if you skip *one* option it doesn't prompt them all
tmeasday Oct 9, 2022
bf40f5c
Add a message while installing in `scripts`
tmeasday Oct 9, 2022
d5c9a9e
Add a nice cancel for `start-from` prompt
tmeasday Oct 10, 2022
e2d7c16
Fix publish script
tmeasday Oct 10, 2022
10ec6d7
Merge remote-tracking branch 'origin/next' into tom/sb-628-properly-d…
tmeasday Oct 10, 2022
c9d876c
Fix issue with global usage
tmeasday Oct 10, 2022
80e313d
Merge remote-tracking branch 'origin/next' into tom/sb-628-properly-d…
tmeasday Oct 10, 2022
7a53b32
Better resolution
tmeasday Oct 10, 2022
3a336b6
Serve the right directory (!)
tmeasday Oct 10, 2022
cbead1a
Update to yarn 3.2.3 everywhere
tmeasday Oct 10, 2022
52740da
Explain the compile `ready` cehck
tmeasday Oct 10, 2022
e42b5b6
Some updates
tmeasday Oct 10, 2022
3d73ef8
Bump cache version
tmeasday Oct 10, 2022
66f1aeb
Update yarn lock in code
tmeasday Oct 10, 2022
f56998e
Merge remote-tracking branch 'origin/next' into tom/sb-628-properly-d…
tmeasday Oct 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Start earlier
tmeasday committed Sep 30, 2022
commit a2ffd0f244888b4a590133411e982d8e8dc5f018
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -485,7 +485,7 @@ jobs:
at: .
- run:
name: Creating Sandboxes
command: yarn task --task sandbox --template $(yarn get-template ci) --no-link --reset=create --junit
command: yarn task --task sandbox --template $(yarn get-template ci) --no-link --reset=run-registry-repo --junit
working_directory: code
- persist_to_workspace:
root: .