Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Add installScripts step in bootstrap command #19270

Merged
merged 8 commits into from
Oct 5, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Sep 27, 2022

Issue: N/A

What I did

A few things:

  • The dependencies from the scripts folder are now updated as a prerequisite of the install step from the bootstrap command. This will happen when running yarn bootstrap --core or yarn bootstrap --install
  • The bootstrap command now gracefully handles quitting with CTRL+C
  • Some scripts were updated as a result of this change
  • Small documentation was updated

How to test

You can remove node_modules from code and scripts then run:

./bootstrap --core

and everything should be good to go.

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Sep 27, 2022
@yannbf yannbf requested a review from tmeasday September 27, 2022 13:55
@shilman shilman changed the title Add installScripts step in boostrap command Build: Add installScripts step in bootstrap command Sep 27, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yannbf 👏

@tmeasday
Copy link
Member

Ok, this is great, although we should be aware we are likely going to to drop bootstrap entirely as part of #19275 (which is still in progress). Perhaps we can look at that together soon @yannbf

@ndelangen ndelangen self-assigned this Oct 5, 2022
@ndelangen ndelangen merged commit 01064b7 into next Oct 5, 2022
@ndelangen ndelangen deleted the install-scripts-bootstrap branch October 5, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants