-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React: Move argType stories to template/stories folder #19265
Conversation
9c07009
to
9e4438a
Compare
It seems as if docgen isn't working in the vite build for JS files, I'm not sure if this is expected @shilman? |
@shilman two things blocking me right now:
|
@tmeasday let's delete the styled components code & bring it back later in the annotations server if we even need it at all As for Jest vs Vite, I think we prefer Vite at this point no question |
It was blowing up the CRA build even though it wasn't being referenced 😠
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for toughing this one out!
The issue here seems to be #17458 -- basically that |
This has come up previously, I think ultimately we would want to move away from doctrine since it’s no longer being supported but for now adding a shim for assert seems like a good mitigation for now. 👍 |
What I did
template/stories
folder..tsx
file, it'll only appear in TS-based react sandboxes.How to test