Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Generic stories for addon-controls #19149

Merged
merged 2 commits into from
Sep 10, 2022
Merged

Build: Generic stories for addon-controls #19149

merged 2 commits into from
Sep 10, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 8, 2022

Issue: N/A

What I did

  • Deleted controls stories from examples
  • Created generic, framework-independent stories to replace them

How to test

  • CI passes

@shilman shilman added maintenance User-facing maintenance tasks addon: controls labels Sep 8, 2022
@shilman shilman requested a review from tmeasday September 9, 2022 02:38
tmeasday
tmeasday approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

code/addons/controls/template/stories/basics.stories.ts Outdated Show resolved Hide resolved
@shilman shilman merged commit 04b519c into next Sep 10, 2022
@shilman shilman deleted the shilman/generic-controls-stories branch September 10, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
addon: controls maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday