React: Fix issue with react 18 implementation #19125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmeasday what's going on with CI here? |
|
Oh, it needs to be updated with this commit: 1cb2f9d which is on the parent branches but hasn't made it in here yet. |
shilman
changed the title
|
Since #18737 was just released in 6.5.11, should this fix be patched back to 6.5 as well? |
|
Yes! |
tmeasday
added
the
patch:yes
shilman
added a commit
that referenced
this pull request
Sep 14, 2022
React: Fix issue with react 18 implementation
|
Very good job 👍 |
3 tasks
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #19118
Issue: When implementing a rendering story that checks a new button isn't created when setting an arg, I realised that I had actually broken things in #18737.
Now we have this story, we shouldn't be able to break things in this way again 🤞
What I did
Changed the react callback behaviour
How to test
useEffecthelper still works (there's ahooks.stories.tsstory for this)