Vite: Don't add babel dependencies during init #19088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
changed the title
IanVS
force-pushed
the
vite/no-install-babel
branch
from
56c23d2 to
9e551e1
Compare
IanVS
force-pushed
the
vite/no-install-babel
branch
from
9e551e1 to
f968c85
Compare
shilman
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Vite projects are getting
babel-loaderand@babel-coredependencies added duringnpx sb init, when they don't need them.In fact, in storybook 7.0, is installing these babel dependencies in a user project ever needed?
What I did
Gated the installation of babel deps in the user's project to non-vite builders.
How to test
CI should tell us if this is a problem, I presume, based on the sandboxes and e2e tests.