Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-viewport: Move stories into addon #19086

Merged
merged 8 commits into from
Sep 2, 2022
Merged

Addon-viewport: Move stories into addon #19086

merged 8 commits into from
Sep 2, 2022

Conversation

ndelangen
Copy link
Member

  • add generic stories for addon-viewports in code/addons/viewports/template/stories
  • remove stories for viewports everywhere else

@ndelangen ndelangen self-assigned this Sep 1, 2022
@ndelangen ndelangen added addon: viewport maintenance User-facing maintenance tasks labels Sep 1, 2022
@ndelangen ndelangen requested a review from shilman September 1, 2022 19:14
shilman
shilman requested changes Sep 2, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except small typos

code/addons/viewport/template/stories/parameters.stories.ts Outdated Show resolved Hide resolved
code/addons/viewport/template/stories/parameters.stories.ts Show resolved Hide resolved
code/addons/viewport/template/stories/parameters.stories.ts Outdated Show resolved Hide resolved
shilman
shilman reviewed Sep 2, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also .stories.ts => .stories.js

@ndelangen ndelangen requested a review from shilman September 2, 2022 10:38
@shilman shilman changed the title move addon-viewports' stories into addons/viewports/template/stories Examples: Move addon-viewport stories into addon Sep 2, 2022
@shilman shilman changed the title Examples: Move addon-viewport stories into addon Addon-viewport: Move stories into addon Sep 2, 2022
Base automatically changed from norbert/sb-575-addon-backgrounds to next September 2, 2022 15:25
@shilman shilman merged commit 9e5d3e0 into next Sep 2, 2022
@shilman shilman deleted the norbert/sb-580-addon-viewport branch September 2, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
addon: viewport maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman