fix(interactions) Blank page when the actions add-on is disabled. #19069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuweiweiwu
requested changes
Aug 31, 2022
| @@ -75,6 +75,11 @@ export const getInteractions = ({ | |||
| }; | |||
|
|
|||
| export const Panel: React.FC<{ active: boolean }> = (props) => { | |||
| // Panel requires an enabled actions addon. | |||
| if (useParameter('actions', { disable: false })?.disable) { | |||
There was a problem hiding this comment.
i would move this to after hook calls as this breaks the rules of hooks https://reactjs.org/docs/hooks-rules.html
There was a problem hiding this comment.
@wuweiweiwu Thank you for your time reviewing my PR!
I initially wrote the logic after all the hook calls and found out the first hook calls caused the blank page issue, so I had to move the validation check before the first useState for the workaround to work correctly.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -
Setting the
actions: { disable: true }parameter locally (or globally) with theinteractions-addoninstalled and loaded will render a blank page.Before:
What I did
I wrote a small workaround to skip the panel rendering if actions are disabled.
After:
How to test
I added a minimal test case inside the
Paneltest suite:yarn test interactions/src/Panel -t 'should render an empty panel'