-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synced changes from new-docs to CONTRIBUTING.md #1906
Synced changes from new-docs to CONTRIBUTING.md #1906
Conversation
… into 1624-viewport-addon
Fix incorrect command
A CLI for running specific tests suites, like bootstrap CLI
Release/3.3
….0.0 Add dependencies.yml for dependencies.io
Update dependencies.yml
Remove greenkeeper & travis ADD BCH & Slack & opencollective
addon-links: add `LinkTo` component, and `hrefTo` function
# Conflicts: # CHANGELOG.md # CONTRIBUTING.md # addons/actions/package.json # addons/centered/package.json # addons/comments/package.json # addons/events/package.json # addons/graphql/package.json # addons/info/package.json # addons/knobs/package.json # addons/links/package.json # addons/notes/package.json # addons/options/package.json # addons/storyshots/package.json # app/react-native/package.json # app/react/package.json # app/vue/package.json # lerna.json # lib/addons/package.json # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/channels/package.json # lib/cli/package.json # lib/codemod/package.json # lib/components/package.json # lib/ui/package.json
Fix root level rendering
CLI: Use actions in sample stories for vue + fix them in SFC_VUE template
Codecov Report
@@ Coverage Diff @@
## master #1906 +/- ##
=======================================
Coverage 21.31% 21.31%
=======================================
Files 257 257
Lines 5737 5737
Branches 691 691
=======================================
Hits 1223 1223
+ Misses 3989 3974 -15
- Partials 525 540 +15
Continue to review full report at Codecov.
|
CONTRIBUTING.md
Outdated
This will watch files and transpile in watch mode. | ||
- node | ||
- yarn | ||
- @storybook/cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ storybook / cli or the whole prerequisites section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cli
package. You either use example app, or your own, which already has storybook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
CONTRIBUTING.md
Outdated
> It's pretty important to create a very simple sample project like above. | ||
> Otherwise some of the functionality won't work because of linking. | ||
1. `yarn bootstrap` | ||
2. At the prompt: `a`, `enter`, `y`, `enter` ( `a` selects all (fully bootstrap) and `y` is to confirm) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a shortcut for it: yarn bootstrap --all
CONTRIBUTING.md
Outdated
cd my-demo-app | ||
getstorybook | ||
``` | ||
This method is slow, and if you are reading this tutorial you probably don't want to do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"if you are reading this tutorial" doesn't apply here
CONTRIBUTING.md
Outdated
``` | ||
### Working with the kitchen sink apps | ||
|
||
Within the examples folder of the Storybook repo, you will find kitchen sink examples of storybook implementations for the various platforms that storybook supports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put examples
in backticks
Please rebase it on |
# Conflicts: # CHANGELOG.md # addons/actions/package.json # addons/comments/package.json # addons/info/package.json # addons/storyshots/package.json # app/react-native/package.json # app/react/package.json # app/vue/package.json # examples/cra-kitchen-sink/src/stories/index.js # lerna.json # lib/ui/package.json
0fcb782
to
ce3b0cb
Compare
New PR (to new-docs) #1911 |
PR Reference: #1886
What I did
Synced CONTRIBUTING.md with updated in
new-docs
branchHow to test
N/A: Just added docs