Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable telemetry in monorepo and CI #18935

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Disable telemetry in monorepo and CI #18935

merged 3 commits into from
Aug 15, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 15, 2022

Issue: N/A

What I did

Disabled telemetry in:

  • stackblitz repros
  • sandbox commands
  • sandbox generated projects

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Aug 15, 2022
shilman
shilman approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 3ddfe20 into next Aug 15, 2022
@shilman shilman deleted the yann/sb-639-add-disable-telemetry-to-mainjs-in branch August 15, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @shilman