Source-loader: Fix invalid call to CSF sanitize #18930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12208
What I did
The error was reported by
sanitize
function, its parameter only accepts thestring
type:https://github.com/ComponentDriven/csf/blob/5654bca6cd222684b0128ee4835258d990d3b526/src/index.ts#L8
We import it to
ts
file in development mode but use it injs
file in production mode, so it misses the type restrict.Here I add an additional type restrict in
js
style, which usestypeof
to determine if its parameter is astring
type.How to test
If your answer is yes to any of these, please make sure to include it in your PR.