-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Polish canvas and sidebar for 7.0 #18894
Conversation
@@ -2,13 +2,15 @@ | |||
<html lang="en"> | |||
<head> | |||
<meta charset="utf-8" /> | |||
<meta name="theme-color" content="<%= themeColor %>" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmeasday Do you have any ideas on how to get the theme color to show here? If not, I can pull this line of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, not sure, I think @ndelangen knows the most about themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No way to do it there, as the theme is determined at runtime.
And in fact can change at runtime.
At least that's how it is at this point, and will likely stay in 7.0 because changing that will be a breaking change.
Currently users define their theme in manager.ts
but in order to know it at build time, it'd have to be moved to main.ts
or some preset value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up Norbert! @MichaelArestad let's punt on this meta tag
3cdb04b
to
b8e5215
Compare
Rebased with the new icons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @yannbf for the story fixes!
What I did
I removed the margins around the preview giving folks back some pixels. This required decoupling the theme's page margin from the draggers, which had some wild side effects before.
How to test