Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy example stories over from renderer + addons #18824

Merged
merged 8 commits into from
Aug 2, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jul 31, 2022

Telescoping on #18827

Issue: https://linear.app/chromaui/issue/SB-581/copy-in-the-rendererframework-specific-stories-based-on-chosen

What I did

  • Created a first example story for react (and one for addon-actions).
  • Add main.js stories entries for the render and each addon
  • Add webpack config to ensure such files use eslint-loader

Screenshots

image

(Note auto title isn't working so great)

image

To follow in later PRs

@tmeasday tmeasday requested a review from yannbf July 31, 2022 12:30
@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Aug 1, 2022
scripts/example.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday force-pushed the tom/sb-581-copy-in-the-rendererframework-specific branch from 57060ea to 9495ec0 Compare August 1, 2022 12:57
@tmeasday tmeasday changed the base branch from next to better-webkit-linking August 1, 2022 12:58
@tmeasday tmeasday force-pushed the better-webkit-linking branch from 7aaa253 to 0f2cb31 Compare August 1, 2022 12:59
@tmeasday tmeasday requested a review from ndelangen August 1, 2022 13:01
scripts/example.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday force-pushed the tom/sb-581-copy-in-the-rendererframework-specific branch from 9495ec0 to d4e108f Compare August 1, 2022 22:35
@tmeasday tmeasday force-pushed the tom/sb-581-copy-in-the-rendererframework-specific branch from 8578466 to 9c80244 Compare August 1, 2022 22:51
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from better-webkit-linking to next August 2, 2022 00:23
@tmeasday tmeasday merged commit c179d1a into next Aug 2, 2022
@tmeasday tmeasday deleted the tom/sb-581-copy-in-the-rendererframework-specific branch August 2, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants