Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update every icon for v7 design #18809

Merged
merged 25 commits into from
Aug 17, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
36ad747
Initial icon update
MichaelArestad Jul 26, 2022
1bf946a
Tweak type requirement
MichaelArestad Jul 28, 2022
d33222e
Updated Icons to be more explicit thanks to Jono
MichaelArestad Aug 1, 2022
a65d6a7
Fix typescript errors - props Shaun on this one
MichaelArestad Aug 3, 2022
d12dfc4
Removed unused bindin
MichaelArestad Aug 3, 2022
cbe28f9
Fixed missing chevrons, fixed icon size in buttons, fixed alert icon …
MichaelArestad Aug 3, 2022
c1b108e
Fixed button sizes and made slight tweak to alignment of icon in Acco…
MichaelArestad Aug 4, 2022
9694d53
Made alert icon slightly smaller in release_notes.tsx
MichaelArestad Aug 4, 2022
4f2d6d4
Added Operating System icons and updated rule
MichaelArestad Aug 4, 2022
c693d12
Fix MenuButton size
MichaelArestad Aug 4, 2022
b482044
Remove icons list from docs FAQ
MichaelArestad Aug 4, 2022
9a42687
Update NotificationItem and updated a handful of icons to match the D…
MichaelArestad Aug 5, 2022
59f9f49
Merge branch 'next' into pr/18809
domyen Aug 11, 2022
3f1f574
Merge branch 'next' into update-every-icon
yannbf Aug 12, 2022
6d1585a
update stories and snapshots
yannbf Aug 12, 2022
f72bbaa
Embiggen the sidebar icons by 2px
domyen Aug 12, 2022
3de325f
Viewport copyedit from "rotate" to "swap" dimensions
domyen Aug 12, 2022
1320ba9
Use the appropriate share icon in Docs Preview Toolbar
domyen Aug 12, 2022
2237d97
Revert "Embiggen the sidebar icons by 2px"
domyen Aug 12, 2022
24da49e
Revert "Viewport copyedit from "rotate" to "swap" dimensions"
domyen Aug 12, 2022
f65602f
Revert "Use the appropriate share icon in Docs Preview Toolbar"
domyen Aug 12, 2022
bb3a2d8
Add icon embed to FAQ
domyen Aug 13, 2022
f1fb9af
Updated bookmark, bookmarkhollow, document, and folder icons
MichaelArestad Aug 16, 2022
162463e
Review feedback
shilman Aug 17, 2022
820b8e4
Merge branch 'next' into update-every-icon
shilman Aug 17, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/addons/a11y/src/components/Report/Item.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const Item = (props: ItemProps) => {
<Wrapper>
<HeaderBar onClick={() => onToggle(!open)} role="button">
<Icon
icon="chevrondown"
icon="arrowdown"
color="#9DA5AB"
style={{
transform: `rotate(${open ? 0 : -90}deg)`,
Expand Down
1 change: 1 addition & 0 deletions code/addons/interactions/src/components/StatusIcon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import localTheme from '../theme';
export interface StatusIconProps {
status: Call['status'];
useSymbol?: IconsProps['useSymbol'];
className?: string;
}

const {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/jest/src/components/Result.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function Result(props: ResultProps) {
<HeaderBar onClick={onToggle} role="button" status={status}>
{status === `failed` ? (
<Icon
icon="chevrondown"
icon="arrowdown"
color={convert(themes.light).color.mediumdark}
style={{
transform: `rotate(${isOpen ? 0 : -90}deg)`,
Expand Down
8 changes: 4 additions & 4 deletions code/lib/components/src/Button/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ const ButtonWrapper = styled.button<{

svg: {
display: 'inline-block',
height: small ? 14 : 16,
width: small ? 14 : 16,
height: small ? 12 : 14,
width: small ? 12 : 14,

verticalAlign: 'top',
marginRight: small ? 4 : 6,
marginTop: small ? -1 : -2,
marginBottom: small ? -1 : -2,
marginTop: small ? 0 : -1,
yannbf marked this conversation as resolved.
Show resolved Hide resolved
marginBottom: small ? 0 : -1,

/* Necessary for js mouse events to not glitch out when hovering on svgs */
pointerEvents: 'none',
Expand Down
2 changes: 1 addition & 1 deletion code/lib/ui/src/components/sidebar/RefIndicator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ const CurrentVersion: FC<CurrentVersionProps> = ({ url, versions }) => {
return (
<Version>
<span>{currentVersionId}</span>
<Icons icon="chevrondown" />
<Icons icon="arrowdown" />
</Version>
);
};
Expand Down
1 change: 1 addition & 0 deletions code/lib/ui/src/settings/release_notes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const AlertIcon = styled(((props) => <Icons icon="alert" {...props} />) as FC<
>)(({ theme }) => ({
color: theme.color.mediumdark,
width: 40,
height: 40,
margin: '0 auto',
}));

Expand Down
26 changes: 13 additions & 13 deletions docs/faq.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
title: 'Frequently Asked Questions'
shilman marked this conversation as resolved.
Show resolved Hide resolved
title: "Frequently Asked Questions"
---

Here are some answers to frequently asked questions. If you have a question, you can ask it by opening an issue on the [Storybook Repository](https://github.com/storybookjs/storybook/).
Expand All @@ -17,7 +17,7 @@ module.exports = {
/* ... */
],
framework: {
name: '@storybook/angular',
name: "@storybook/angular",
options: {
enableIvy: false,
},
Expand Down Expand Up @@ -53,7 +53,7 @@ You can generally reuse webpack rules by placing them in a file that is `require
```js
module.exports = {
webpackFinal: async (baseConfig) => {
const nextConfig = require('/path/to/next.config.js');
const nextConfig = require("/path/to/next.config.js");

// merge whatever from nextConfig into the webpack config storybook will use
return { ...baseConfig, ...nextConfig };
Expand All @@ -77,7 +77,7 @@ FAST_REFRESH=true
```js
module.exports = {
framework: {
name: '@storybook/react-webpack5',
name: "@storybook/react-webpack5",
options: {
fastRefresh: true,
},
Expand All @@ -98,7 +98,7 @@ You can opt-out from the new React Root API by setting the following property in
```js
module.exports = {
framework: {
name: '@storybook/react-webpack5',
name: "@storybook/react-webpack5",
options: {
legacyRootApi: true,
},
Expand All @@ -113,7 +113,7 @@ A common error is that an addon tries to access the "channel", but the channel i
1. You're trying to access addon channel (e.g., by calling `setOptions`) in a non-browser environment like Jest. You may need to add a channel mock:

```js
import { addons, mockChannel } from '@storybook/addons';
import { addons, mockChannel } from "@storybook/addons";

addons.setChannel(mockChannel());
```
Expand All @@ -128,7 +128,7 @@ If you're adding Storybook's dependencies manually, make sure you include the [`
// .storybook/main.js

module.exports = {
addons: ['@storybook/addon-controls'],
addons: ["@storybook/addon-controls"],
};
```

Expand Down Expand Up @@ -235,7 +235,7 @@ Go through this [story](https://5a375b97f4b14f0020b0cda3-wbeulgbetj.chromatic.co
| beaker | bell | bitbucket | book | bookmark |
| bookmarkhollow | bottombar | box | branch | browser |
| button | calendar | camera | category | certificate |
| check | chevrondown | chromatic | circle | circlehollow |
| check | | chromatic | circle | circlehollow |
| close | closeAlt | cog | collapse | comment |
| commit | compass | component | contrast | copy |
| cpu | credit | cross | dashboard | database |
Expand Down Expand Up @@ -418,15 +418,15 @@ We're aware that the default Typescript story construct might seem outdated and
```ts
// Button.stories.ts | tsx

import React from 'react';
import type { ComponentStory, ComponentMeta } from '@storybook/react';
import React from "react";
import type { ComponentStory, ComponentMeta } from "@storybook/react";

const StoryMeta: ComponentMeta<typeof Button> = {
/* 👇 The title prop is optional.
* See https://storybook.js.org/docs/react/configure/overview#configure-story-loading
* to learn how to generate automatic titles
*/
title: 'Button',
title: "Button",
component: Button,
};

Expand Down Expand Up @@ -454,7 +454,7 @@ export default {
component: MyComponent,
args: {
//👇 Defining the arg's value at the component level.
text: 'Something',
text: "Something",
},
};
```
Expand All @@ -469,7 +469,7 @@ export default {
argTypes: {
//👇 Defining the arg's display value in docs.
text: {
table: { defaultValue: { summary: 'SomeType<T>' } },
table: { defaultValue: { summary: "SomeType<T>" } },
},
},
};
Expand Down