Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix default framework options handling #18676

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 11, 2022

fixes: #18635 (comment)

So this:

framework = await presets.apply('framework')

Will return the setting from main.js from the user only.
It will not contain any additional frameworkOptions.

main.js is always last in the chain, so we need a new property to merge the options with the default

@nx-cloud
Copy link

nx-cloud bot commented Jul 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 30fd916. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Jul 11, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jul 11, 2022
@shilman shilman changed the title fix frameworkOptions loading Core: Fix default framework options handling Jul 11, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pattern is slightly weird, since it allows users to override framework and frameworkOptions independently. However, I don't have a better proposal! 🤷

Base automatically changed from future/base to next July 25, 2022 10:37
# Conflicts:
#	code/lib/core-server/src/presets/common-preset.ts
@ndelangen ndelangen merged commit b677750 into next Aug 2, 2022
@ndelangen ndelangen deleted the future/frameworkOptions-preset-value branch August 2, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants