Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumenter: SyncPayload type for sync event #18674

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

ghengeveld
Copy link
Member

What I did

Added a type for the event payload, to add some guarantees about its signature.

@ghengeveld ghengeveld added the maintenance User-facing maintenance tasks label Jul 10, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jul 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2651299. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ghengeveld ghengeveld requested a review from shilman July 10, 2022 19:57
@ghengeveld ghengeveld changed the base branch from next to future/base July 10, 2022 19:57
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld merged commit 76e95a1 into future/base Jul 11, 2022
@ghengeveld ghengeveld deleted the sync-payload-type branch July 11, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants