bug: always create main with cjs extension

[benmccann]

Issue: #9854

What I did

Fixed an issue in npx sb init for SvelteKit projects

What extension svelte.config.js uses is irrelevant. Storybook doesn't support ESM, so you have to use the .cjs extension if package.json contains "type": "module" (which all new SvelteKit projects do). Just always using .cjs is easiest and will always work

How to test

• Is this testable with Jest or Chromatic screenshots? not sure
• Does this need a new example in the kitchen sink apps? no
• Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 70d2e77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[ndelangen]

This only affects the svelte generator? Yeah should be OK I guess!

[benmccann]

The Svelte generator is the only one that uses the commonJs option. I updated this file alone because I'm just trying to get Storybook working with SvelteKit (sveltejs/kit#5397)

It wouldn't be a bad idea for Storybook to just remove the option and always create the file with a .cjs extension since that would make Storybook work in any project regardless of whether the user adds "type": "module". Or alternatively Storybook could read the package.json and check the value of the type field to decide on the extension to use, but that would only make it work in the case that the user updates the type field and then runs the generator and not the other way around. But making either of those changes seemed outside the scope of just getting this working for Svelte projects

[ndelangen]

I'll bring it up with the team, thanks for the suggestion!

[ndelangen]

I'm pretty sure with our change in 7.0 (future/base branch) this whole commonjs option/toggle can be removed. Users will be able to write CJS, TS or MJS files, and it will all just work, thanks to esbuild-register

[shilman]

@benmccann @ndelangen Should we patch this back to 6.5?

[benmccann]

Yes, please

[yannbf]

I'd say this change should be released in 6.5 and then undone for 7.0.0, given @ndelangen's explanation with esbuild-register!