Svelte: Make svelte-loader optional dependency

[benmccann]

What I did

Make svelte-loader optional so that we don't add webpack support when using @storybook/builder-vite. You just need one or the other

How to test

• Is this testable with Jest or Chromatic screenshots? - probably doesn't need this type of test
• Does this need a new example in the kitchen sink apps? - no. existing apps work the same, but just install more quickly
• Does this need an update to the documentation? - no. existing apps work the same, but just install more quickly

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 807c5be. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[ndelangen]

Hello @benmccann Thank you for this contribution, unfortunately We're working on a massive refactor that splits apps into frameworks, presets and renderers. Frameworks will introduce a builder.
You can find this work in the future/base branch.

I don't think I can merge this PR, because it adds dependencies to the svelte app in such a way users would always / often get both builders. The refactor I described above, is all about preventing that.

I'm appreciative of your time, energy and work you put into this PR. I'm sorry for closing it.

The future/base should make it's way into next soon. @shilman is on vacation right now, and so we'll wait for a bit. Also future/base needs to mature just a little bit more.

[benmccann]

I don't think I can merge this PR, because it adds dependencies to the svelte app in such a way users would always / often get both builders.

I don't think that's true because @storybook/builder-vite was added as optional. I'm happy to remove any reference to @storybook/builder-vite though as it's in no way necessary. While we're waiting for the larger refactor, it would be extremely helpful if we could still consider the portion of this PR which makes svelte-loader optional. I discussed this with @IanVS before sending the PR. Is it possible we could reopen this?

[IanVS]

Peer deps are weird, some package managers install them automatically, some don't. I'd suggest removing the vite builder from this PR, and just keeping the optional dep on the webpack loader. I think that still makes sense to be optional, since this addon can be used with the vite builder without it.

[ndelangen]

Absolutely!

[benmccann]

Thanks guys! I've made that change

[IanVS]

LGTM, thanks.

Except, it looks like you'll need to run yarn install, and check in the lockfile, to get the Danger JS ci job passing.

[benmccann]

oops. updated! thanks for taking a look 😄

[IanVS]

Hmmmm, I'm not sure why it's failing now. It seems it can't get some user information, but I'm not familiar with this CI check or how it works.

[IanVS]

Does anyone know what might be happening with the CI on this PR?

[shilman]

@IanVS I've just added @benmccann to the Storybook github org. Once he accepts his invite the CI should run. It's a security thing.

[shilman]

@IanVS @benmccann does this need to be patched back to 6.5?

[IanVS]

It would be nice if it were, yeah.

[benmccann]

I accepted the invite. I'm not quite sure how to kick off the CI again. I tried rerunning the jobs, but nothing appears to be happening

Let me know if there's anything I need to do for the 6.5 backport. Otherwise I'll assume you guys are handling that

[shilman]

@benmccann try merging in next to create a new commit. i'll handle the patch at some point soon, don't worry about it 👍

[benmccann]

I merged in next, but it doesn't seem to be running the CI yet. Though I think it's unlikely this change will affect anything the CI tests anyway, so we could probably merge it without running the CI