Future - improve linting a bit #18642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8c0d7be. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndelangen
commented
Jul 6, 2022
Comment on lines
-33
to
-41
| child_process.exec( | ||
| `yarn lint:js:cmd --fix ${location}`, | ||
| { | ||
| cwd: path.join(__dirname, '..', '..', '..'), | ||
| }, | ||
| () => { | ||
| console.log('Done!'); | ||
| } | ||
| ); |
There was a problem hiding this comment.
This wasn't awaited, so could be stopped mid-process if build failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eslint CLI flag to only show errors in lint output,
Because scrolling past 10000 warnings isn't helping..
Why we have so many warning? you ask?
🦗