Docs2: Extract doc blocks into a separate package #18587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 36027e1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
@shilman do you want to pull @lifeiscontent's changes from #18478 too? |
tmeasday
reviewed
Jun 29, 2022
lib/blocks/package.json
Outdated
Comment on lines
37
to
46
| "@storybook/addons": "7.0.0-alpha.6", | ||
| "@storybook/api": "7.0.0-alpha.6", | ||
| "@storybook/client-logger": "7.0.0-alpha.6", | ||
| "@storybook/components": "7.0.0-alpha.6", | ||
| "@storybook/core-events": "7.0.0-alpha.6", | ||
| "@storybook/csf": "0.0.2--canary.7c6c115.0", | ||
| "@storybook/docs-tools": "7.0.0-alpha.6", | ||
| "@storybook/preview-web": "7.0.0-alpha.6", | ||
| "@storybook/store": "7.0.0-alpha.6", | ||
| "@storybook/theming": "7.0.0-alpha.6", |
There was a problem hiding this comment.
How are we thinking about the dependencies of this package? We might need to discuss @shilman. In particular I am interested in the thinking behind pulling some but not all of the dependencies from @storybook/components into this package.
There was a problem hiding this comment.
Ideally this doesn't pull anything form @storybook/components, but I think we'll need to tackle that later on.
…drewluca/18323 # Conflicts: # .circleci/config.yml # SECURITY.md # addons/a11y/src/components/VisionSimulator.test.tsx # app/vue/src/client/preview/config.ts # app/vue3/src/client/preview/config.ts # docs/addons/writing-addons.md # docs/api/cli-options.md # docs/builders/webpack.md # docs/configure/css-troubleshooting/angular.mdx # docs/contribute/code.md # docs/contribute/new-snippets.md # docs/essentials/interactions.md # docs/essentials/introduction.md # docs/faq.md # docs/get-started/install.md # docs/sharing/publish-storybook.md # docs/snippets/common/button-story-project-args-theme.js.mdx # docs/snippets/common/storybook-main-enable-transcludemarkdown.js.mdx # docs/snippets/common/storybook-main-with-single-static-dir.js.mdx # docs/snippets/common/storybook-test-runner-install.npm.js.mdx # docs/snippets/common/storybook-test-runner-install.yarn.js.mdx # docs/snippets/common/storybook-vite-builder-aliasing.js.mdx # docs/writing-stories/build-pages-with-storybook.md # docs/writing-stories/play-function.md # docs/writing-tests/snapshot-testing.md # docs/writing-tests/visual-testing.md # examples/vue-3-cli/.storybook/main.js # examples/vue-cli/.storybook/main.js # examples/vue-kitchen-sink/.storybook/main.js # examples/vue-kitchen-sink/.storybook/preview.js # examples/vue-kitchen-sink/src/App.vue # examples/vue-kitchen-sink/src/stories/__snapshots__/core.stories.storyshot # examples/vue-kitchen-sink/src/stories/__snapshots__/custom-decorators.stories.storyshot # examples/vue-kitchen-sink/src/stories/core.stories.js # lib/cli/src/generators/ANGULAR/angular-helpers.ts # lib/cli/src/generators/ANGULAR/index.ts # lib/components/package.json # lib/components/src/blocks/ArgsTable/ArgsTable.tsx # lib/components/src/blocks/Source.tsx # lib/components/src/spaced/Spaced.tsx # lib/components/src/tabs/tabs.tsx # lib/core-server/package.json # lib/preview-web/src/Preview.tsx # lib/preview-web/src/PreviewWeb.integration.test.ts # lib/preview-web/src/PreviewWeb.mockdata.ts # lib/preview-web/src/PreviewWeb.test.ts # lib/preview-web/src/PreviewWeb.tsx # lib/ui/src/index.tsx # yarn.lock
…ybook into future/doc-blocks-take2
# Conflicts: # addons/controls/package.json # addons/docs/package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Joint work with @okonet. This replaces #18429 which got somehow very tangled in git despite being a set of relatively simple changes.
@storybook/blockspackageexamples/doc-blocksstorybook@storybook/components@storybook/blockswhere appropriateHow to test
Also: