Addon-docs: Produce docs page entries in the index #18574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit efa1d76. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
changed the base branch from
next
to
tom/sb-450-index-docspage-processing-configuration
tmeasday
force-pushed
the
tom/sb-449-index-update-generation-to-produce
branch
2 times, most recently
from
e35167e to
d263a18
Compare
tmeasday
force-pushed
the
tom/sb-450-index-docspage-processing-configuration
branch
from
ae3be2b to
1642483
Compare
tmeasday
force-pushed
the
tom/sb-449-index-update-generation-to-produce
branch
2 times, most recently
from
379b85b to
75b818a
Compare
|
Note preview-side tests are failing on this branch, which is unsurprising |
tmeasday
force-pushed
the
tom/sb-450-index-docspage-processing-configuration
branch
from
1642483 to
814885f
Compare
tmeasday
force-pushed
the
tom/sb-449-index-update-generation-to-produce
branch
from
a682561 to
62153f3
Compare
shilman
changed the title
tmeasday
force-pushed
the
tom/sb-450-index-docspage-processing-configuration
branch
from
ab17703 to
c547333
Compare
tmeasday
force-pushed
the
tom/sb-449-index-update-generation-to-produce
branch
from
62153f3 to
70737e2
Compare
|
@tmeasday bunch of failing tests. i guess these get fixed in a subsequent PR? |
Yes, that's right. |
tmeasday
force-pushed
the
tom/sb-450-index-docspage-processing-configuration
branch
from
c547333 to
45f141b
Compare
Template (standalone: false) entries are needed for: - Docs Page - *.stories.mdx files that define a docs page and stories. A Template entry expects to be rendered from and against a story file. (A standalone entry expects to be rendered as a MDX file)
tmeasday
force-pushed
the
tom/sb-449-index-update-generation-to-produce
branch
from
70737e2 to
095a5a9
Compare
Base automatically changed from
tom/sb-450-index-docspage-processing-configuration
to
future/base
July 7, 2022 23:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #18573
Update Story Indexer to produce template and standalone docs entries, including template entries for the docs page feature.
Template (
standalone: false) entries are needed for:A Template entry expects to be rendered from and against a story file. (A standalone entry expects to be rendered as a MDX file)
Drop the legacy vs modern distinction -- a legacy entry is just a specific case of a template entry and they can be handled similarly in the preview.
This branch changes the sidebar, but the entries do not render in the preview (see #18595)