Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Use TSUP to compile the frameworks #18543

Merged
merged 12 commits into from
Jun 29, 2022
Merged

Conversation

ndelangen
Copy link
Member

let's try converting frameworks to use tsup as well, now that I'm here

@nx-cloud
Copy link

nx-cloud bot commented Jun 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e4e20c1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Jun 22, 2022
@ndelangen ndelangen self-assigned this Jun 22, 2022
# Conflicts:
#	frameworks/html-webpack5/package.json
#	frameworks/preact-webpack5/package.json
#	frameworks/react-webpack5/package.json
#	frameworks/server-webpack5/package.json
#	frameworks/svelte-webpack5/package.json
#	frameworks/vue-webpack5/package.json
#	frameworks/vue3-webpack5/package.json
#	frameworks/web-components-webpack5/package.json
#	yarn.lock
@ndelangen ndelangen requested a review from shilman June 23, 2022 12:03
Base automatically changed from future/tsup-renderers-1 to future/base June 29, 2022 10:45
@shilman shilman changed the title Use TSUP to compile the frameworks Build: Use TSUP to compile the frameworks Jun 29, 2022
@shilman shilman closed this Jun 29, 2022
@shilman shilman reopened this Jun 29, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YOLO!!! 🚀

@shilman shilman merged commit ad680d1 into future/base Jun 29, 2022
@shilman shilman deleted the future/tsup-frameworks-1 branch June 29, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants