Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs2 core: Fetch index.json for composition #18521

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

tmeasday
Copy link
Member

What I did

Fetch index.json as well as stories.json and prefer the former.

How to test

See tests. Also try composing new + old SBs.

@nx-cloud
Copy link

nx-cloud bot commented Jun 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cf6e741. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

tmeasday added 2 commits June 21, 2022 13:19
cc @ndelangen - composition was broken after remove the `importPolyfills().then` from here.
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💪

@shilman shilman merged commit 063383c into future/docs2-core Jun 21, 2022
@shilman shilman deleted the tom/sb-443-fetch-indexjson-from-refs branch June 21, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants