Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: improve HTML framework's generated typescript stories #18509

Closed
wants to merge 1 commit into from
Closed

examples: improve HTML framework's generated typescript stories #18509

wants to merge 1 commit into from

Conversation

Matthew-Smith
Copy link
Contributor

Issue:

What I did

The example stories for the typescript version of the HTML Framework had some issues that caused typescript to complain. This improves that and also adds a section to the HTML Framework readme to explain how to get the typescript versions of the examples when starting from a new project.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jun 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7f47c01. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch typescript html labels Jun 19, 2022
@MichaelArestad MichaelArestad requested a review from yannbf June 27, 2022 14:52
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Matthew-Smith thanks a lot! This is amazing 🚀🚀

@Matthew-Smith
Copy link
Contributor Author

@yannbf is there a reason this PR was closed? I'm happy to fix it up if there are any changes needed

@yannbf
Copy link
Member

yannbf commented Jun 30, 2022

Great question @Matthew-Smith , this should not have been closed, but merged instead. I'm on holidays so I can't do much but @ndelangen could you please take a look? Thank you!!

@ndelangen ndelangen reopened this Jul 1, 2022
@ndelangen ndelangen assigned ndelangen and unassigned yannbf Jul 1, 2022
@ndelangen
Copy link
Member

@ndelangen
Copy link
Member

I need to update this branch with next so I'll close this PR, and open a new one..

@Matthew-Smith
Copy link
Contributor Author

I see now! Sorry about the confusion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli html patch:yes Bugfix & documentation PR that need to be picked to main branch typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants