-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: improve HTML framework's generated typescript stories #18509
examples: improve HTML framework's generated typescript stories #18509
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7f47c01. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Matthew-Smith thanks a lot! This is amazing 🚀🚀
@yannbf is there a reason this PR was closed? I'm happy to fix it up if there are any changes needed |
Great question @Matthew-Smith , this should not have been closed, but merged instead. I'm on holidays so I can't do much but @ndelangen could you please take a look? Thank you!! |
@Matthew-Smith It closed because you deleted the fork: |
I need to update this branch with |
I see now! Sorry about the confusion! |
Issue:
What I did
The example stories for the typescript version of the
HTML Framework
had some issues that caused typescript to complain. This improves that and also adds a section to theHTML Framework
readme to explain how to get the typescript versions of the examples when starting from a new project.How to test
If your answer is yes to any of these, please make sure to include it in your PR.