UI: Fix display skip to sidebar button #18479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Skip to Sidebar button was not visible or executable after striking ENTER on the "Skip to Canvas" button and then striking TAB.
What I did
Made the "Skip to Sidebar" button visible and focusable by reverting a previous change. For context, click here to see where the breaking change occurred.
Screenshots
Before:
before.mov
After:
after.mov
How to test
Run a build and view the core storybook. Hit TAB until "Skip to Canvas" is selected, strike ENTER, strike TAB -- Skip to Sidebar button should be selected.
If your answer is yes to any of these, please make sure to include it in your PR.