Telemetry: Strip out preset from addon name #18442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also move getStorybookMetadata method to the bottom so it's used after the definition of computeStorybookMetadata
yannbf
added
bug
patch:yes
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 56694e9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
commented
Jun 9, 2022
| @@ -204,3 +188,19 @@ export const computeStorybookMetadata = async ({ | |||
| hasStorybookEslint, | |||
| }; | |||
| }; | |||
|
|
|||
| let cachedMetadata: StorybookMetadata; | |||
There was a problem hiding this comment.
no changes here, just moved the code down
Codecov Report
@@ Coverage Diff @@
## next #18442 +/- ##
=======================================
Coverage 32.01% 32.01%
=======================================
Files 975 975
Lines 19234 19234
Branches 4033 4033
=======================================
Hits 6158 6158
- Misses 12512 12513 +1
+ Partials 564 563 -1
Continue to review full report at Codecov.
|
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jun 12, 2022
…eset Telemetry: Strip out preset from addon name
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Take into account that some addons are registered with
'addon-name/preset'and strip that out in the metadata.Also move getStorybookMetadata method to the bottom so it's used after the definition of computeStorybookMetadata, as eslint has warned:
How to test
If your answer is yes to any of these, please make sure to include it in your PR.