Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story index: Ensure that extract script works and SBs can be composed into v6 storybooks #18409

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jun 6, 2022

What I did

  • Keep legacy fields on both store.getStoriesJsonData() (used by the extract script) and /stories.json (legacy endpoint).

How to test

  • I added a simple test for the stories.json converter
  • I tested sb extract (unchanged) still works with v7 docs2 SB (react-ts)
  • I tested the extracted SB (local and prod) can be composed into a 6.3 Storybook.

@tmeasday tmeasday requested a review from shilman June 6, 2022 07:07
@nx-cloud
Copy link

nx-cloud bot commented Jun 6, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6513bb6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday changed the base branch from next to future-hybrid-stories-index June 6, 2022 07:07
lib/store/src/types.ts Outdated Show resolved Hide resolved
@shilman shilman added core story index maintenance User-facing maintenance tasks cli labels Jun 7, 2022
@shilman shilman changed the title Ensure that extract script works and SBs can be composed into v6 storybooks Story index: Ensure that extract script works and SBs can be composed into v6 storybooks Jun 7, 2022
@shilman shilman merged commit 4a7fd09 into future-hybrid-stories-index Jun 7, 2022
@shilman shilman deleted the tom/sb-336-figure-out-extract branch June 7, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli core maintenance User-facing maintenance tasks story index
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants