feat(cli): Add support for angular/[email protected] #18334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e5841e4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
yannbf
reviewed
May 30, 2022
yannbf
reviewed
May 30, 2022
yannbf
requested changes
May 30, 2022
There was a problem hiding this comment.
Good stuff @stefanoslig, thanks for your contribution!
I added a couple comments
stefanoslig
force-pushed
the
feat/angular-cli-default-project-deprecation
branch
from
8601ed1 to
e5841e4
Compare
yannbf
approved these changes
Jun 2, 2022
yannbf
added
linear
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jun 3, 2022
…roject-deprecation feat(cli): Add support for angular/[email protected]
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18316
What I did
I have explained already in the issue what is the problem.
When the
angular.jsonfile doesn't contain thedefaultProjectproperty (which is the case when you create a project with angular/[email protected]), then the default project is the first available project.The solution is backwards compatible with the previous versions of the angular-cli
How to test
storybook/examplesfolder runng new sb-ng14npx sb initMaybe there is a better way to test it
If your answer is yes to any of these, please make sure to include it in your PR.