-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade file-system-cache to 2.0.0 and remove custom types #18253
Conversation
We are using @storybook/core-common in our project and it pulls [email protected] --> [email protected]. We need to use [email protected] which [email protected] uses.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 265631b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Hey @vinodkumarsharma276 thanks for this PR! You'll need to update the lock file. Did you make sure to check whether there were no breaking changes in 2.0.0 that could impact the package? |
@@ -72,7 +72,7 @@ | |||
"chalk": "^4.1.0", | |||
"core-js": "^3.8.2", | |||
"express": "^4.17.1", | |||
"file-system-cache": "^1.0.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, but would you mind updating the lockfile with the PR too?
😮 whut ? |
We are using @storybook/core-common in our project and it pulls [email protected] --> [email protected]. We need to use [email protected] which [email protected] uses.
Issue:
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.