Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): add type guard for globalWindow #18251

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

nnnnoel
Copy link
Contributor

@nnnnoel nnnnoel commented May 18, 2022

Issue:

What I did

I added type guard before globalWindow.addEventListener function for check browser objects is available.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented May 18, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 846d3fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@nnnnoel nnnnoel changed the title fix(chore): type guard for globalWindow fix(chore): add type guard for globalWindow May 18, 2022
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nnnnoel thanks for your contribution. This change seems good!
Could you please update the description of the PR? it's currently blank. Thanks!

@nnnnoel
Copy link
Contributor Author

nnnnoel commented May 24, 2022

@yannbf Updated.

@nnnnoel nnnnoel requested a review from yannbf May 24, 2022 10:42
@ndelangen ndelangen merged commit 2d3cfe5 into storybookjs:next Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants