Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Update Introduction.stories.mdx template to be MDX2-friendly #18141

Merged
merged 1 commit into from
May 5, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented May 5, 2022

Issue: N/A

What I did

Update our sample MDX to be MDX2-compatible per mdx-js/mdx#1945

One less step for new users. Existing users will need to update by hand.

Self-merging @tmeasday

How to test

Follow instructions here: https://gist.github.com/shilman/6ff2d7e18db8846e8fc552fb432ae4f6#gotchas

@shilman shilman added maintenance User-facing maintenance tasks cli mdx labels May 5, 2022
@nx-cloud
Copy link

nx-cloud bot commented May 5, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ff14ce5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman self-assigned this May 5, 2022
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 5, 2022
@shilman shilman merged commit 305cb2b into next May 5, 2022
@shilman shilman deleted the fix/mdx2-introduction-in-cli-template branch May 5, 2022 02:51
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks mdx patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant