-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Add a parent level toolbar exclusion key for tabs #18106
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1ea0c5c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about *
which is a bit more idiomatic?
Also, does this need to be documented somewhere?
762af41
to
9e86957
Compare
@shilman do you mean something like |
@JonathanKolnik Discussed with the triage team. Initial consensus is that this is a weird API. How about |
While we're at it, we should rename |
4b286d6
to
4bc8479
Compare
4bc8479
to
d50ed19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonathanKolnik small nit, but it looks like the new story looks just like the default story, i.e. there are no tabs to hide so it doesn't really test the feature.
🤦♂️ updated @shilman thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for fixing up the test case @JonathanKolnik -- looking great
Issue:
Sometimes you might want to exclude tabs altogether but you can't know the specific addon keys that could populate the tabs section of the toolbar ahead of time.
What I did
Added a parent level toolbar exclusion key
storybook/tabs
that follows the same API as the rest of the toolbar exclusions but filters out all tabs in the toolbar section.How to test