-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs2: Handle new docs entries in the preview #18099
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dffce1e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ad2c719
to
ce7a34e
Compare
8ee1e28
to
39f93de
Compare
39f93de
to
e4b9bd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmeasday Not sure how to best review this one. I agree with the changes in principle per our discussions.
There's still one unit test failure to take care of! 🙏
I would look closely at the changes to:
|
87f2203
to
443ecdf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% awesome! So many improvements in here
Telescoping on #18023
moduleExport
when processing/preparing a storyloadDocsEntry
function that pre-loadsstoryImports
DocsRenderer
toaddon-docs
and rationalize import behaviourof={}
behaviour toStory
element