Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Remove standalone node APIs #18089

Merged
merged 5 commits into from
Jun 19, 2022
Merged

Core: Remove standalone node APIs #18089

merged 5 commits into from
Jun 19, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 28, 2022

Issue: N/A

What I did

Now that we have a framework field in main.js we can just call the core-server API, reducing our surface area.

See added section in MIGRATION.md for details

Self-merging @tmeasday

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented Apr 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 033235f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the base branch from next to future/base April 28, 2022 09:23
@shilman shilman added maintenance User-facing maintenance tasks BREAKING CHANGE core labels Apr 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 033235f

@shilman shilman removed the maintenance User-facing maintenance tasks label Jun 19, 2022
@shilman shilman merged commit 8cc4e6c into future/base Jun 19, 2022
@shilman shilman deleted the future/remove-app-apis branch June 19, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant