Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX failing scripts exiting with 0 #1807

Merged
merged 2 commits into from
Sep 6, 2017
Merged

FIX failing scripts exiting with 0 #1807

merged 2 commits into from
Sep 6, 2017

Conversation

ndelangen
Copy link
Member

Issue: -some script were not exiting correctly

What I did

made sure they exit with 1 when there's an error somewhere.

@ndelangen ndelangen added cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks labels Sep 6, 2017
@ndelangen ndelangen self-assigned this Sep 6, 2017
@ndelangen ndelangen merged commit 22e7180 into master Sep 6, 2017
@codecov
Copy link

codecov bot commented Sep 6, 2017

Codecov Report

Merging #1807 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1807   +/-   ##
=======================================
  Coverage   21.32%   21.32%           
=======================================
  Files         257      257           
  Lines        5739     5739           
  Branches      700      696    -4     
=======================================
  Hits         1224     1224           
+ Misses       3984     3975    -9     
- Partials      531      540    +9
Impacted Files Coverage Δ
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/info/src/components/Props.js 36.36% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4c192...6e1ddab. Read the comment docs.

@ndelangen ndelangen deleted the ndelangen/fix-cli branch September 6, 2017 16:09
@ndelangen
Copy link
Member Author

Sorry about the self-merge, this is actually a rather critical issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant