-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Make renderers presets #18004
Merged
Merged
Core: Make renderers presets #18004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 00965dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
Core: Make renderers presets
Core: Make renderers presets (2/N)
May 4, 2022
2 tasks
shilman
changed the title
Core: Make renderers presets (2/N)
Core: Make renderers presets (1a/N)
May 11, 2022
shilman
changed the title
Core: Make renderers presets (1a/N)
Core: Make renderers presets
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Telescoping PR, builds on #17982
What I did
This extends the renderer refactor to make renderers presets because each package now as a
preview.js
entry point per #17755Discussion
This PR has a few potential issues.
Always executes docs code. In #17982, the framework presets only runs the docs preview code if
addon-docs
/addon-controls
is installed. This new, stylized, version doesn't do that.May contain more functionality than originally discussed. When we discussed renderers, there were certain features such as
ArgType
enhancement that would potentially be handled by other packages (whereas source snippet rendering might be handled by the renderer). This is also a problem with #17982. Related to the previous point, but different.Are presets the right abstraction? We also discussed having a formal API for renderers rather than using Storybook's presets API. For now that's out of scope, but noting it here as potential future work.
How to test