Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Make renderers presets #18004

Merged
merged 13 commits into from
May 11, 2022
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 19, 2022

Issue: N/A

Telescoping PR, builds on #17982

What I did

This extends the renderer refactor to make renderers presets because each package now as a preview.js entry point per #17755

Discussion

This PR has a few potential issues.

Always executes docs code. In #17982, the framework presets only runs the docs preview code if addon-docs/addon-controls is installed. This new, stylized, version doesn't do that.

May contain more functionality than originally discussed. When we discussed renderers, there were certain features such as ArgType enhancement that would potentially be handled by other packages (whereas source snippet rendering might be handled by the renderer). This is also a problem with #17982. Related to the previous point, but different.

Are presets the right abstraction? We also discussed having a formal API for renderers rather than using Storybook's presets API. For now that's out of scope, but noting it here as potential future work.

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented Apr 19, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 00965dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the base branch from next to future/add-renderers April 19, 2022 16:53
@shilman shilman changed the title Future/renderer presets Core: Make renderers presets Apr 21, 2022
@shilman shilman added the maintenance User-facing maintenance tasks label Apr 21, 2022
@shilman shilman changed the title Core: Make renderers presets Core: Make renderers presets (2/N) May 4, 2022
@shilman shilman marked this pull request as ready for review May 11, 2022 11:27
@shilman shilman merged commit 2f15d65 into future/add-renderers May 11, 2022
@shilman shilman deleted the future/renderer-presets branch May 11, 2022 11:37
@shilman shilman mentioned this pull request May 11, 2022
1 task
@shilman shilman changed the title Core: Make renderers presets (2/N) Core: Make renderers presets (1a/N) May 11, 2022
@shilman shilman changed the title Core: Make renderers presets (1a/N) Core: Make renderers presets Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant