-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Fix ability to use component-level play functions #17817
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d5cd800. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Co-authored-by: Yann Braga <[email protected]>
@wKich getting a typescript error in CI. can you please update the types?
|
Hm... It looks like |
@shilman Should I revert that commit ComponentDriven/csf@85efd3c ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think it was @tmeasday who might've had objections to the component-level play function
I don't have an issue unless I am forgetting something. |
@shilman let's proceed with this change! But first merge ComponentDriven/csf#40 and release a new version of course |
Socket Security Pull Request Report👍 No dependency changes detected in pull request Pull request report summary
Powered by socket.dev |
scripts/package.json
Outdated
@@ -3,16 +3,16 @@ | |||
"version": "7.0.0-alpha.16", | |||
"private": true, | |||
"scripts": { | |||
"docs:prettier:check": "cd ../docs && prettier --check ./snippets", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this change happened in the PR but I guess it makes sense, with the scripts being ordered alphabetically
Merging this as the failure is unrelated and has been fixed in |
Issue: Nope
What I did
Fix ability to use
play
function defined in Meta levelHow to test
If your answer is yes to any of these, please make sure to include it in your PR.