-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Typing useArgs #17735
Core: Typing useArgs #17735
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8f8213f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @saiichihashimoto -- thanks so much!!!
Any chance you can add an example that demonstrates the feature as part of examples/official-storybook
? 🙏
I'm not sure how to go about this @shilman, a little help? There's a lot going on there. |
Not sure if you're able to help me here @shilman, not sure how to go about adding examples tbh. |
I updated with an example! Works great, thank you for this @saiichihashimoto ! @shilman I'll merge this as soon as it's green, because this change just makes sense to me. |
Issue:
useArgs is great, but it would be nice to type it so it can conform with my component props.
What I did
[string]
rather than being an array as it should be.