Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci:matrix label in CI #17457

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Fix ci:matrix label in CI #17457

merged 1 commit into from
Feb 10, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Feb 9, 2022

Issue: none

What I did

In my own project, I attempted to set up a similar github workflow, which would not run unless a tag was present. After experimenting a bit, I found that the way the check here in storybook is set up is not correct. The approach in this PR is what I landed on in my own project, and seems to work correctly.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

Verify that the unit test matrix does not run on this PR. Add the label, verify that the unit test matrix starts running. Push a commit to the PR, verify that they run again.

@IanVS IanVS added the maintenance User-facing maintenance tasks label Feb 9, 2022
@nx-cloud
Copy link

nx-cloud bot commented Feb 9, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 3d15c11. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix @IanVS 🙏

@shilman shilman merged commit 62c7dc5 into next Feb 10, 2022
@shilman shilman deleted the ci-matrix-label branch February 10, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants