CSF3: Handle auto-title redundant filename #17421
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit 39b3e6e. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
| ) | ||
| ).toMatchInlineSnapshot(`To/Button`); | ||
| }); | ||
|
|
There was a problem hiding this comment.
What's the outcome of a test with this?
auto(
'./path/to/button/index.stories.js',
normalizeStoriesEntry({ directory: './path' }, options)
)There was a problem hiding this comment.
To/Button/Index -- do you think we should remove Index?
There was a problem hiding this comment.
I'd say so, normally index is ommited when importing e.g.
import { Button } from './components/Button'so personally I'd expect a similar behavior. @tmeasday @ndelangen WDYT?
There was a problem hiding this comment.
Yeah, "Index" is meaningless to everyone, we should ignore it.
There was a problem hiding this comment.
Do we also cope with just stories.js? I feel like that filename would make sense for a folder.
There was a problem hiding this comment.
There was an issue in the eslint-plugin-storybook repo about supporting stories.js files. We never suggest that though, and I believe our internal defaults are all about *.stories.*. Do you think we should support stories.* ? I've never seen people having something like test.js in their folders, just index.test.js or Component.test.js
There was a problem hiding this comment.
I've seen it before, but I'm OK with saying it's not something we recommend.
shilman
changed the title
shilman
changed the title
Issue: #15534
What I did
Technically breaking change in experimental auto-title:
Input:
atoms/button/button.stories.jsAtoms/Button/ButtonAtoms/ButtonInput:
atoms/button/index.stories.jsAtoms/Button/IndexAtoms/ButtonSee attached migration notes for full explanation
How to test
See attached test